[ 
https://issues.apache.org/jira/browse/HBASE-13063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343952#comment-14343952
 ] 

Enis Soztutar commented on HBASE-13063:
---------------------------------------

+1 with two nits. 

1. You can increment the skipped edits counter for all edits that are skipped. 
We do this in many places and helps with debugging, etc. 
2. The ordering between checking the memstore replication state and isMetaEdit 
can be reversed. I think it boils down to whether we expect most of the tables 
will have it disabled or enabled. 

> Allow to turn off memstore replication for region replicas
> ----------------------------------------------------------
>
>                 Key: HBASE-13063
>                 URL: https://issues.apache.org/jira/browse/HBASE-13063
>             Project: HBase
>          Issue Type: New Feature
>          Components: regionserver, Replication
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13063-v0.patch, HBASE-13063-v1-branch-1.patch, 
> HBASE-13063-v1.patch, HBASE-13063-v1.patch
>
>
> HBASE-11568 allows to use replication to send wal edits from the primary to 
> the replicas.
> sometimes the memstore replication is not required, so it will be nice have a 
> flag to disable it.
> the result will be more or less the same to what we have in phase-1, but with 
> the row-level consistency provided by the "flush" edit transfered via 
> replication to refresh the hfiles.
> create 't1', 'f', {REGION_REPLICATION => 2, REGION_MEMSTORE_REPLICATION => 
> false}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to