[
https://issues.apache.org/jira/browse/HBASE-13122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344511#comment-14344511
]
ramkrishna.s.vasudevan commented on HBASE-13122:
------------------------------------------------
{code}
if (familyLength > 0) {
if (doCompare(this.compareOp, this.comparator, v.getFamilyArray(),
v.getFamilyOffset(), familyLength)) {
- return ReturnCode.SKIP;
+ return ReturnCode.NEXT_ROW;
}
}
{code}
I doubt this change. Suppose I have 2 families and the first family is what I
want to filter then how can I move to the next_row?
In the tests that was done
bq.scan use familyFilter get values from the second family, scaned 2000 rows
and 100 versions of each row& qualifier.
Use the oraginal FamilyFilter, cost average 309 seconds, but with the improved
familyFilter, the cost is average 38 seconds, improved about 700%
The values were got from the secondFamily so that would not be a problem. But
if it had been the first family we would have missed the cells? Pls correct me
if am wrong here.
> Improve efficiency for return codes of some filters
> ---------------------------------------------------
>
> Key: HBASE-13122
> URL: https://issues.apache.org/jira/browse/HBASE-13122
> Project: HBase
> Issue Type: Improvement
> Components: Filters
> Affects Versions: 0.94.24, 1.0.1, 0.98.10.1
> Reporter: Shuaifeng Zhou
> Fix For: 2.0.0, 1.1.0
>
> Attachments: 13122-master.patch, 13122.patch
>
>
> ColumnRangeFilter:
> when minColumnInclusive is false, it means all the cells at the current
> row&column not fit the condition, so it should skip to next column, return
> code should be NEXT_COL, not SKIP.
> FamilyFilter is the similar sitution.
> Currently, SKIP will not causing error, but not efficent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
