[
https://issues.apache.org/jira/browse/HBASE-12405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350031#comment-14350031
]
Hadoop QA commented on HBASE-12405:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12702978/HBASE-12405_4.patch
against master branch at commit 8449251fb647a93c3c6f66295a5bfd770f1031d3.
ATTACHMENT ID: 12702978
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 8 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ storeCompleteSequenceId_ =
java.util.Collections.unmodifiableList(storeCompleteSequenceId_);
+ storeCompleteSequenceId_ =
java.util.Collections.unmodifiableList(storeCompleteSequenceId_);
+ new java.lang.String[] { "RegionSpecifier", "Stores",
"Storefiles", "StoreUncompressedSizeMB", "StorefileSizeMB", "MemstoreSizeMB",
"StorefileIndexSizeMB", "ReadRequestsCount", "WriteRequestsCount",
"TotalCompactingKVs", "CurrentCompactedKVs", "RootIndexSizeKB",
"TotalStaticIndexSizeKB", "TotalStaticBloomSizeKB", "CompleteSequenceId",
"DataLocality", "LastMajorCompactionTs", "StoreCompleteSequenceId", });
+ storeLastFlushedSequenceId_ =
java.util.Collections.unmodifiableList(storeLastFlushedSequenceId_);
+ storeLastFlushedSequenceId_ =
java.util.Collections.unmodifiableList(storeLastFlushedSequenceId_);
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13115//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13115//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13115//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13115//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13115//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13115//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13115//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13115//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13115//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13115//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13115//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13115//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13115//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13115//console
This message is automatically generated.
> WAL accounting by Store
> -----------------------
>
> Key: HBASE-12405
> URL: https://issues.apache.org/jira/browse/HBASE-12405
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Affects Versions: 2.0.0, 1.1.0
> Reporter: zhangduo
> Assignee: zhangduo
> Fix For: 2.0.0, 1.1.0
>
> Attachments: HBASE-12405.patch, HBASE-12405_1.patch,
> HBASE-12405_2.patch, HBASE-12405_3.patch, HBASE-12405_4.patch
>
>
> HBASE-10201 has made flush decisions per Store, but has not done enough work
> on HLog, so there are two problems:
> 1. We record minSeqId both in HRegion and FSHLog, which is a duplication.
> 2. There maybe holes in WAL accounting.
> For example, assume family A with sequence id 1 and 3, family B with
> seqId 2. If we flush family A, we can only record that WAL before sequence id
> 1 can be removed safely. If we do a replay at this point, sequence id 3 will
> also be replayed which is unnecessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
