[ https://issues.apache.org/jira/browse/HBASE-4482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114888#comment-13114888 ]
jirapos...@reviews.apache.org commented on HBASE-4482: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2051/#review2071 ----------------------------------------------------------- src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java <https://reviews.apache.org/r/2051/#comment4667> Can you comment here on the change? And should this use LOG instead of System.out? src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java <https://reviews.apache.org/r/2051/#comment4668> add a reference to the JIRA # in this comment... and break this to two lines. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java <https://reviews.apache.org/r/2051/#comment4669> remove from javadoc src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java <https://reviews.apache.org/r/2051/#comment4670> Do we need this? At the least should be a DEBUG (seems like RS logs will be filled with this though, is that intended?) - Jonathan On 2011-09-26 19:17:34, Li Pi wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/2051/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-09-26 19:17:34) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. ------- bq. bq. Bugfix, kills a race condition. bq. bq. Ignore r1, thats the wrong patch. bq. bq. bq. This addresses bug HBASE-4482. bq. https://issues.apache.org/jira/browse/HBASE-4482 bq. bq. bq. Diffs bq. ----- bq. bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SingleSizeCache.java 3798a06 bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java fe8b95a bq. src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabItemEvictionWatcher.java 91b1603 bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 0c06f4f bq. src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java fd9e7ef bq. src/test/java/org/apache/hadoop/hbase/io/hfile/CacheTestUtils.java 0814f41 bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSingleSizeCache.java e021780 bq. src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java 8dd5159 bq. bq. Diff: https://reviews.apache.org/r/2051/diff bq. bq. bq. Testing bq. ------- bq. bq. Looped tests. bq. bq. bq. Thanks, bq. bq. Li bq. bq. > Race Condition Concerning Eviction in SlabCache > ----------------------------------------------- > > Key: HBASE-4482 > URL: https://issues.apache.org/jira/browse/HBASE-4482 > Project: HBase > Issue Type: Sub-task > Reporter: Li Pi > Assignee: Li Pi > Priority: Critical > Fix For: 0.92.0 > > Attachments: hbase-4482v1.txt, hbase-4482v2.txt > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira