[
https://issues.apache.org/jira/browse/HBASE-13169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353785#comment-14353785
]
Enis Soztutar commented on HBASE-13169:
---------------------------------------
Thanks for taking a look.
bq. Wondering if any special handling is needed if modification goes in
"opposite" direction, say from 3 to 1 num of reps?
We auto-add the replication peer when a table with region replicas is created
or a table is modified to have replicas (with this patch). However, there is
not yet support for auto-removing the replication peer if the last table with
region replicas is deleted or replication is reduced to 1 via modify table. We
do not have a global lock on all the table operations in master so doing an
atomic check for "is this the last table with replicas" is hard to do.
bq. does this work for the online table modification case?
Right now, online modifying a table for increasing region replicas is not
supported (see ModifyTableHandler.prepareWithTableLock()).
bq. seems like the remove and add replicas would be good to have in one method,
or pull the "ifNeeded" check into handleTableOperation to make it look parallel.
I see your point. These two cases are doing different things (removing from
meta vs adding a replication peer). Having separate methods should be good.
> ModifyTable increasing the region replica count should also auto-setup RRRE
> ---------------------------------------------------------------------------
>
> Key: HBASE-13169
> URL: https://issues.apache.org/jira/browse/HBASE-13169
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 2.0.0, 1.1.0
>
> Attachments: hbase-13169_v1.patch
>
>
> This is a follow up to Async WAL replication jira (HBASE-11568). In
> HBASE-11568 we setup replication automatically in create table if the
> configuration is enabled.
> We should do the same in case a table with region replication = 1 is
> modified, and region replication is set to >1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
