[
https://issues.apache.org/jira/browse/HBASE-13167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356476#comment-14356476
]
Hadoop QA commented on HBASE-13167:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12703544/HBASE-13167.patch
against master branch at commit b436db7d70c8a90b0167dc0e0120f503efb37e3c.
ATTACHMENT ID: 12703544
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13176//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13176//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13176//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13176//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13176//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13176//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13176//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13176//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13176//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13176//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13176//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13176//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13176//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13176//console
This message is automatically generated.
> The check for balancerCutoffTime is buggy
> -----------------------------------------
>
> Key: HBASE-13167
> URL: https://issues.apache.org/jira/browse/HBASE-13167
> Project: HBase
> Issue Type: Bug
> Components: Balancer
> Affects Versions: 0.98.8
> Reporter: Tianyin Xu
> Attachments: HBASE-13167.patch
>
>
> In HMaster, the checking logic for balancerCutoffTime in buggy.
> See the following code:
> {code:title=HMaster.java|borderStyle=solid}
> 1419 private int getBalancerCutoffTime() {
> 1420 int balancerCutoffTime =
> 1421 getConfiguration().getInt("hbase.balancer.max.balancing", -1);
> 1422 if (balancerCutoffTime == -1) {
> 1423 // No time period set so create one
> 1424 int balancerPeriod =
> 1425 getConfiguration().getInt("hbase.balancer.period", 300000);
> 1426 balancerCutoffTime = balancerPeriod;
> 1427 // If nonsense period, set it to balancerPeriod
> 1428 if (balancerCutoffTime <= 0) balancerCutoffTime = balancerPeriod;
> 1429 }
> 1430 return balancerCutoffTime;
> 1431 }
> {code}
> Basically, the check for "nonsense period" is no effect, because
> balancerCutoffTime is always assigned to be balancerPeriod whatever the value
> is.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
