[ 
https://issues.apache.org/jira/browse/HBASE-13208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357369#comment-14357369
 ] 

Sean Busbey commented on HBASE-13208:
-------------------------------------

{code}
-    if [[ $patchName =~ .*$LOCAL_BRANCH_NAME.* ]]; then
+    if [[ $patchName =~ /jira/secure/attachment/[0-9]*/.*$LOCAL_BRANCH_NAME 
]]; then
{code}

you need a wildcard on the end, other wise we'll skip all hte patches that 
include e.g. ".1.patch" or ".1.patch.txt"

> Patch build should match the patch filename and not the whole relative URL in 
> findBranchNameFromPatchName
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13208
>                 URL: https://issues.apache.org/jira/browse/HBASE-13208
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Esteban Gutierrez
>            Assignee: Esteban Gutierrez
>            Priority: Trivial
>         Attachments: 
> 0001-HBASE-13208-Patch-build-should-match-the-patch-filen.patch
>
>
> In HBASE-1319 we saw that the patch got applied to the wrong branch, the 
> problem is findBranchNameFromPatchName matching a regex that contains 
> wildcard symbols against the whole URL, in this case the regex is 0.94 and 
> the relativePatchURL is /jira/secure/attachment/12703942/HBASE-13193-v4.patch 
> where 0394 is a match.
> Thanks to  [~jonathan.lawlor] for reporting this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to