[ 
https://issues.apache.org/jira/browse/HBASE-13193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357833#comment-14357833
 ] 

Hadoop QA commented on HBASE-13193:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12704001/HBASE-13193-v4.patch
  against master branch at commit 2adec36b2f57fea7006036e5a1f4d5979737ab34.
  ATTACHMENT ID: 12704001

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13198//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13198//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13198//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13198//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13198//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13198//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13198//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13198//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13198//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13198//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13198//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13198//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13198//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13198//console

This message is automatically generated.

> RegionScannerImpl filters should not be reset if a partial Result is returned
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-13193
>                 URL: https://issues.apache.org/jira/browse/HBASE-13193
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jonathan Lawlor
>            Assignee: Jonathan Lawlor
>         Attachments: HBASE-13193-v1.patch, HBASE-13193-v2.patch, 
> HBASE-13193-v3.patch, HBASE-13193-v4.patch, HBASE-13193-v4.patch, 
> HBASE-13193-v4.patch, HBASE-13193-v5.patch
>
>
> In RegionScannerImpl the filters get reset during calls to nextRaw:
> {code}
> public NextState nextRaw(List<Cell> outResults, int batchLimit, long 
> remainingResultSize)
>         throws IOException {
>   ...
>   resetFilters();
>   if (isFilterDoneInternal()) {
>   ...
> }
> {code}
> This creates a problem when returning partial Results because filters should 
> only be reset in between rows (i.e. after all of the cells for a particular 
> row have been returned). If a partial Result is returned, there are still 
> cells in the row that have not been evaluated yet and we should avoid 
> resetting the filter since it will wipe away all state information for that 
> filter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to