[ 
https://issues.apache.org/jira/browse/HBASE-13205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358644#comment-14358644
 ] 

Hadoop QA commented on HBASE-13205:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12704138/HBASE-13205-v2-branch-1.patch
  against branch-1 branch at commit ff8840acc3d3f258c933c91b275922d6528b6893.
  ATTACHMENT ID: 12704138

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 38 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 
3807 checkstyle errors (more than the master's current 3806 errors).

    {color:red}-1 findbugs{color}.  The patch appears to introduce 9 new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +  protected QuotaSettings(final String userName, final TableName 
tableName, final String namespace) {
+              new java.lang.String[] { "UserName", "UserGroup", "Namespace", 
"TableName", "RemoveAll", "BypassGlobals", "Throttle", });
+        result = result && (Float.floatToIntBits(getShare())    == 
Float.floatToIntBits(other.getShare()));
+      "imit\030\002 \001(\004\022\r\n\005share\030\003 
\001(\002\022#\n\005scope\030\004 \001(\016" +
+              new java.lang.String[] { "ReqNum", "ReqSize", "WriteNum", 
"WriteSize", "ReadNum", "ReadSize", });
+  public void postSetNamespaceQuota(final String namespace, final Quotas 
quotas) throws IOException {
+    if (!MetaTableAccessor.tableExists(masterServices.getConnection(), 
QuotaUtil.QUOTA_TABLE_NAME)) {
+  private static void doDelete(final Connection connection, final Delete 
delete) throws IOException {

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13217//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13217//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13217//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13217//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13217//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13217//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13217//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13217//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13217//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13217//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13217//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13217//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13217//artifact/patchprocess/checkstyle-aggregate.html

                Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13217//console

This message is automatically generated.

> [branch-1] Backport HBASE-11598 Add simple rpc throttling
> ---------------------------------------------------------
>
>                 Key: HBASE-13205
>                 URL: https://issues.apache.org/jira/browse/HBASE-13205
>             Project: HBase
>          Issue Type: Task
>          Components: security
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>              Labels: multitenancy, quota
>             Fix For: 1.1.0
>
>         Attachments: HBASE-13205-branch-1.patch, 
> HBASE-13205-v1-branch-1.patch, HBASE-13205-v2-branch-1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to