[ 
https://issues.apache.org/jira/browse/HBASE-13224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359713#comment-14359713
 ] 

Matteo Bertozzi commented on HBASE-13224:
-----------------------------------------

the patch is ok, but since you add the comma both in the if and in the else, 
you can do like the user does. and remove the comma inside the if (and avoid 
the else)
{code}
sb.append("scope=")
        .append(namespace != null ? namespace : table == null ? "GLOBAL" : 
table);
        .append(", ");
{code}

> Minor formatting issue when logging a namespace scope in 
> AuthResult#toContextString
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-13224
>                 URL: https://issues.apache.org/jira/browse/HBASE-13224
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors, security
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Esteban Gutierrez
>            Priority: Trivial
>         Attachments: 
> 0001-HBASE-13224-Minor-formatting-issue-when-logging-a-na.patch
>
>
> Now that we handle namespace permissions AuthResult#toContextString is not 
> correctly formatted:
> {code}
> Access denied for user esteban; reason: Insufficient permissions; remote 
> address: /10.20.30.1; request: createTable; context: (user=esteban@XXX, 
> scope=defaultaction=CREATE)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to