[
https://issues.apache.org/jira/browse/HBASE-13267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14365970#comment-14365970
]
Mikhail Antonov commented on HBASE-13267:
-----------------------------------------
Yeah. The only little concern here I could see is that having default
implementation returning false makes it easier for implementers to forget to
override the method (no compile-time check), hence preventing any files from
being deleted. Maybe it isn't really important though.
> Deprecate or remove isFileDeletable from SnapshotHFileCleaner
> -------------------------------------------------------------
>
> Key: HBASE-13267
> URL: https://issues.apache.org/jira/browse/HBASE-13267
> Project: HBase
> Issue Type: Task
> Reporter: Andrew Purtell
> Priority: Minor
> Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12
>
>
> The isFileDeletable method in SnapshotHFileCleaner became vestigial after
> HBASE-12627, lets remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
