[
https://issues.apache.org/jira/browse/HBASE-13211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370356#comment-14370356
]
Ted Yu commented on HBASE-13211:
--------------------------------
{code}
100 message DisableTableMessage {
101 required UserInformation user_info = 1;
102 required TableName table_name = 2;
103 required bool skip_table_state_check = 3;
104 }
{code}
Looks like the above can be unified with EnableTableMessage
{code}
1663 // TODO: return procId as part of client-side change
1664 // return procId;
{code}
Would the above be done in the next patch ?
{code}
102 case MARK_REGIONS_OFFLINE:
103 // If the making region offline gets interrupted, we will retry
the step.
{code}
How would the retry timeout ?
For MarkRegionsOffline(), false is returned when bd.bulkAssign() returns false,
or method being interrupted. Should we distinguish these two conditions ?
{code}
88 protected void completionCleanup(final MasterProcedureEnv env) {
189 // Remove the run-queue of the table
190 if (!env.getProcedureQueue().markTableAsDisabled(tableName)) {
191 // There are requests in the queue (e.g. a new create)
192 return;
193 }
194 }
{code}
Did you plan to handle the else branch with some action ? Otherwise the if
statement seems unnecessary.
{code}
254 if (tableName.equals(TableName.META_TABLE_NAME)) {
255 throw new ConstraintException("Cannot disable catalog table");
256 }
{code}
Should TableName.isSystemTable() be used above ?
{code}
409 protected boolean waitUntilDone(long timeout) throws
InterruptedException {
410 long startTime = System.currentTimeMillis();
{code}
Please use EnvironmentEdgeManager.
> Procedure V2 - master Enable/Disable table
> ------------------------------------------
>
> Key: HBASE-13211
> URL: https://issues.apache.org/jira/browse/HBASE-13211
> Project: HBase
> Issue Type: Sub-task
> Components: master
> Affects Versions: 2.0.0, 1.1.0
> Reporter: Stephen Yuan Jiang
> Assignee: Stephen Yuan Jiang
> Labels: reliability
> Attachments: EnableDisableTableServerPV2-draft.v0-master.patch
>
> Original Estimate: 120h
> Time Spent: 48h
> Remaining Estimate: 72h
>
> master side, part of HBASE-12439
> starts up the procedure executor on the master
> and replaces the enable/disable table handlers with the procedure version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
