[
https://issues.apache.org/jira/browse/HBASE-13209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372301#comment-14372301
]
Ted Yu commented on HBASE-13209:
--------------------------------
{code}
+ private void waitforProcedureToComplete(final long procId) throws
IOException {
+ while (!this.procedureExecutor.isFinished(procId) &&
this.procedureExecutor.isRunning()) {
{code}
Should there be a timeout for the wait ?
{code}
+ * The procedure to add a column family from an existing table.
{code}
Typo: 'from an' -> 'to an'
{code}
+ switch (state) {
+ case ADD_COLUMN_FAMILY_POST_OPERATION:
+ // TODO: should it call DeleteColumnFamilyProcedure.postDelete()?
+ break;
+ case ADD_COLUMN_FAMILY_UPDATE_TABLE_DESCRIPTOR:
+ // TODO: should it call
DeleteColumnFamilyProcedure.updateTableDescriptor()?
+ break;
+ case ADD_COLUMN_FAMILY_PRE_OPERATION:
+ // TODO: should it call DeleteColumnFamilyProcedure.preDelete()?
{code}
The TODO's were meant for delete column family, right ?
{code}
+ for (HRegionInfo hri : hris) {
+ // Delete the family directory in FS for all the regions one by one
+ mfs.deleteFamilyFromFS(hri, familyName);
{code}
What if IOE is thrown from mfs.deleteFamilyFromFS() ?
> Procedure V2 - master Add/Modify/Delete Column Family
> -----------------------------------------------------
>
> Key: HBASE-13209
> URL: https://issues.apache.org/jira/browse/HBASE-13209
> Project: HBase
> Issue Type: Sub-task
> Components: master
> Affects Versions: 2.0.0, 1.1.0
> Reporter: Stephen Yuan Jiang
> Assignee: Stephen Yuan Jiang
> Labels: reliability
> Attachments: AlterColumnFamilyServerPV2-draft.v0-master.patch
>
> Original Estimate: 168h
> Time Spent: 72h
> Remaining Estimate: 96h
>
> master side, part of HBASE-12439
> starts up the procedure executor on the master
> and replaces the add/modify/delete handlers with the procedure version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
