[
https://issues.apache.org/jira/browse/HBASE-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372540#comment-14372540
]
Lars Hofhansl commented on HBASE-13307:
---------------------------------------
Cool! Haven't thought in this direction at all.
It's a bit weird though to change code just to make inlining better. Can we
increase -XX:MaxInlineSize instead? Apparently it default to 35 bytes (yes
bytes). Maybe we can set it to 100 (or another good value that inlines the
methods we want).
I'm gonna try that now (or tomorrow).
> Making methods under ScannerV2#next smaller allows them to be inlined gaining
> us 7% more throughput
> ---------------------------------------------------------------------------------------------------
>
> Key: HBASE-13307
> URL: https://issues.apache.org/jira/browse/HBASE-13307
> Project: HBase
> Issue Type: Sub-task
> Components: Scanners
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0, 1.1.0
>
> Attachments: 13307.txt
>
>
> See parent issue for patch and evidence.
> I was looking at graphs of our scan and found that methods were 'too big' to
> be inlined (looking at jvm compilation and inlining output flags -- see
> parent for list). Changing method size helped some. Let me commit the
> resultant patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
