[
https://issues.apache.org/jira/browse/HBASE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117022#comment-13117022
]
jirapos...@reviews.apache.org commented on HBASE-4510:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2108/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming
refactorings were carried out.
Two solutions:
1. We use new classnames. This breaks HBase's backward compatibility with older
Hadoop releases (is that a concern with future releases?)
2. HBase gets its own sets of constants as the upstream one is not marked for
public usage. This needs a little more maintenance on HBases' side.
Way (2) seems more viable. I've attached an initial patch that doesn't fix all
trouble yet, but introduces the first way of changes.
The remaining issue lies in the use of DistributedFileSystem's safemode methods
(which are private audience as well) inside of HBase for safemode waits and
checks (via HBases' FSUtils class). Since this uses an enum, it is more
difficult to handle without upstream interventions - thoughts?
This addresses bug HBASE-4510.
https://issues.apache.org/jira/browse/HBASE-4510
Diffs
-----
src/main/java/org/apache/hadoop/hbase/util/FSHDFSUtils.java dcd0937
Diff: https://reviews.apache.org/r/2108/diff
Testing
-------
Thanks,
Harsh
> HDFS-1620 related changes downstream (For compiling with HDFS 0.23+)
> --------------------------------------------------------------------
>
> Key: HBASE-4510
> URL: https://issues.apache.org/jira/browse/HBASE-4510
> Project: HBase
> Issue Type: Task
> Affects Versions: 0.94.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Blocker
>
> HBase isn't seemingly compiling anymore on 0.23 after the HDFS-1620 naming
> refactorings were carried out.
> Two solutions:
> * We use new classnames. This breaks HBase's backward compatibility with
> older Hadoop releases (is that a concern with future releases?)
> * HBase gets its own sets of constants as the upstream one is not marked for
> public usage. This needs a little more maintenance on HBases' side.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
