[ 
https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117074#comment-13117074
 ] 

Ted Yu commented on HBASE-4487:
-------------------------------

Wow, this is the quickest turnaround for code review I have ever seen :-)
Normally you can wait for other people's comments before making the next patch.

I still see System.err.println() call.
For my last comment, thanks for reminding me the current behavior. What I meant 
was that your change introduced some kind of buffering which would delay the 
bubbling of IOException.
I guess this is Okay. We should document this in release notes.

Can I ask my favorite question ? Test suite.

Also, using https://reviews.apache.org/ would be convenient.
                
> The increment operation can release the rowlock before sync-ing the Hlog
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4487
>                 URL: https://issues.apache.org/jira/browse/HBASE-4487
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: appendNoSync4.txt, appendNoSync5.txt
>
>
> This allows for better throughput when there are hot rows.I have seen this 
> change make a single row update improve from 400 increments/sec/server to 
> 4000 increments/sec/server.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to