[ https://issues.apache.org/jira/browse/HBASE-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117093#comment-13117093 ]
jirapos...@reviews.apache.org commented on HBASE-4509: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2111/ ----------------------------------------------------------- Review request for hbase, Todd Lipcon and Michael Stack. Summary ------- This is on top of HBASE-4506 but doesn't require it. commit 17d3b8856a8e7c803463fb37b1bd4691d0a02ba9 Author: Jonathan Hsieh <j...@cloudera.com> Date: Wed Sep 28 20:32:02 2011 -0700 HBASE-4509 [hbck] Improve region map output Details: HBASE-4375 added a region coverage visualization to hbck in details mode. When users have binary row keys the output is difficult to parse (awk/sed) or pull into programs (numeric, excel) capable of handling tsv formatted data. This patch: * improves output by using Bytes.toStringBinary (which escapes binary) instead of Bytes.toString when printing keys, * suggests some repair actions, and * collects "overlap group" that groups regions that are overlapping. This addresses bug HBASE-4509. https://issues.apache.org/jira/browse/HBASE-4509 Diffs ----- src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 8465724 src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java fae0881 Diff: https://reviews.apache.org/r/2111/diff Testing ------- Updated unit test passes. Used on a live cluster to get better information when dianosing problem. Thanks, jmhsieh > [hbck] Improve region map output > -------------------------------- > > Key: HBASE-4509 > URL: https://issues.apache.org/jira/browse/HBASE-4509 > Project: HBase > Issue Type: Improvement > Affects Versions: 0.92.0, 0.94.0, 0.90.5 > Reporter: Jonathan Hsieh > Assignee: Jonathan Hsieh > Attachments: 0001-HBASE-4509-hbck-Improve-region-map-output.patch > > > HBASE-4375 added a region coverage visualization to hbck in details mode. > When users have binary row keys the output is difficult to parse (awk/sed) or > pull into programs (numeric, excel) capable of handling tsv formatted data. > This patch > * improves output by using Bytes.toStringBinary (which escapes binary) > instead of Bytes.toString when printing keys, > * suggests some repair actions, and > * collects "problem group" that groups regions that are overlapping. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira