[
https://issues.apache.org/jira/browse/HBASE-13332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380914#comment-14380914
]
Andrew Purtell commented on HBASE-13332:
----------------------------------------
While reviewing the patch for backports I've found some cases where Table and
Connection are substituted for use of HTable within doAs, and some cases where
not. Why not all cases? I'm looking at TestVisibilityLabelsWithACL
specifically. Also looks like you stopped making replacements of HTable and
try-finally with Table+Connection in try-with-resources here.
Some tests also leak unclosed HTable references. This isn't the fault of the
patch but why not clean up while in there (and get rid of HTable in the
process)?
There's no 0.98 patch, did you want to try and resolve the same issues in that
branch too? We can proceed with just the commit of the master patch as is. Let
me know.
> Fix the usage of doAs/runAs in Visibility Controller tests.
> -----------------------------------------------------------
>
> Key: HBASE-13332
> URL: https://issues.apache.org/jira/browse/HBASE-13332
> Project: HBase
> Issue Type: Sub-task
> Reporter: Srikanth Srungarapu
> Assignee: Srikanth Srungarapu
> Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12
>
> Attachments: HBASE-13332.patch, HBASE-13332.patch
>
>
> The "doAs" bug is also affecting VC related tests too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
