[ 
https://issues.apache.org/jira/browse/HBASE-13316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381345#comment-14381345
 ] 

Ted Yu commented on HBASE-13316:
--------------------------------

{code}
+   * @param admin
+   * @param regionInfo
+   *
+   */
+  public static void warmupRegion(final AdminService.BlockingInterface admin,
+      final ServerName server, final HRegionInfo regionInfo) throws 
IOException  {
{code}
Javadoc for parameter server is missing.

In RequestConverter :
{code}
+  public static WarmupRegionRequest buildWarmupRegionRequest(ServerName server,
{code}
Parameter server is not used in the body of the above method.

In HMaster :
{code}
+      serverManager.sendRegionWarmup(rp.getDestination(), hri);
{code}
Since the above call is synchronous, should there be a config that allows user 
to select whether the warmup is carried out ?

It would be easier for reviewers if the patch is published on review board.

> Reduce the downtime on planned moves of regions
> -----------------------------------------------
>
>                 Key: HBASE-13316
>                 URL: https://issues.apache.org/jira/browse/HBASE-13316
>             Project: HBase
>          Issue Type: Improvement
>          Components: Balancer
>    Affects Versions: 2.0.0, 1.0.1, 1.1.1
>            Reporter: Sameet Agarwal
>            Assignee: Sameet Agarwal
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: PlannedFailover-v1.patch, PlannedFailover.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> The current behavior of a region move shuts down a region and then starts is 
> up in another regionserver. This causes increased latency and possibly 
> timeouts till the new region's cache is fully warmed up. We can make a region 
> move less disruptive by warming the cache in the destination region server 
> before shutting dow the old region.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to