[ 
https://issues.apache.org/jira/browse/HBASE-13303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383181#comment-14383181
 ] 

Hadoop QA commented on HBASE-13303:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12707635/HBASE-13303-addendum-v1.patch
  against master branch at commit 18256fc9544866fc7182dfc5dd9d73b8cef02d66.
  ATTACHMENT ID: 12707635

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13453//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13453//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13453//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13453//console

This message is automatically generated.

> Fix size calculation of results on the region server
> ----------------------------------------------------
>
>                 Key: HBASE-13303
>                 URL: https://issues.apache.org/jira/browse/HBASE-13303
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client
>            Reporter: Lars Hofhansl
>            Assignee: Andrew Purtell
>             Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.12
>
>         Attachments: HBASE-13303-0.98.patch, HBASE-13303-0.98.patch, 
> HBASE-13303-0.98.patch, HBASE-13303-addendum-v1.patch, HBASE-13303.patch, 
> HBASE-13303.patch, HBASE-13303.patch, TestResultSizeEstimation.java
>
>
> One of the problems in the parent is due to different size calculation 
> between client and server when HFilev3 is used.
> Since tags are _never_ shipped to the client in a scan, we can have special 
> size function (or a flag on the current one) that does not include the tags 
> and the tags meta information (the length is what causes the issue), so that 
> client and server will always calculate the same size.
> I'll make a patch within the hour, unless somebody beats me to it.
> [~apurtell], FYI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to