[ 
https://issues.apache.org/jira/browse/HBASE-13219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383516#comment-14383516
 ] 

Anoop Sam John commented on HBASE-13219:
----------------------------------------

I am +1 for this change and making multiCon as false by default..  (By default 
use single connection).  Ping [~nkeywal]
[~ndimiduk]
{code}
+final String oneCon = "--oneCon=";
+if (cmd.startsWith(oneCon)) {
+  System.err.println("--oneCon option is deprecated, it is now the default 
behavior.");
+}
+final String multiCon = "--multiCon=";
+  if (cmd.startsWith(multiCon)) {
+    opts.multiCon = Boolean.parseBoolean(cmd.substring(multiCon.length()));
+}
{code}
You missing a continue statement?
When user passed the deprecated --oneCon , still we have to use it with negate? 
Or exit with error?  Simply disregard this is correct?


> Issues with PE tool in trunk
> ----------------------------
>
>                 Key: HBASE-13219
>                 URL: https://issues.apache.org/jira/browse/HBASE-13219
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: 13219.txt, t1
>
>
> -> PE tool tries to create the TEstTable and waits for it to be enabled and 
> just hangs there 
> Previously this was not happening and the PE tool used to run fine after the 
> table creation.
> -> When we try to scan with 25 threads the PE tool fails after some time 
> saying Unable to create native threads.
> I lost the Stack trace now. But I could get it easily.  It happens here 
> {code}
>   public void submit(RetryingCallable<V> task, int callTimeout, int id) {
>     QueueingFuture<V> newFuture = new QueueingFuture<V>(task, callTimeout);
>     executor.execute(Trace.wrap(newFuture));
>     tasks[id] = newFuture;
>   }
> {code}
> in ResultBoundedCompletionService. This is also new.  Previously it used to 
> work with 25 threads without any issues. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to