[ 
https://issues.apache.org/jira/browse/HBASE-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383686#comment-14383686
 ] 

ramkrishna.s.vasudevan commented on HBASE-13320:
------------------------------------------------

[~sreenivasulureddy]
Did you try to start a region server with the above changed default value?
Because here
{code}
int blockSize = c.getInt(BLOCKCACHE_BLOCKSIZE_KEY, 
HConstants.DEFAULT_BLOCKSIZE);
    float bucketCachePercentage = c.getFloat(BUCKET_CACHE_SIZE_KEY, 0F);
    long bucketCacheSize = (long) (bucketCachePercentage < 1? mu.getMax() * 
bucketCachePercentage:
      bucketCachePercentage * 1024 * 1024);
    if (bucketCacheSize <= 0) {
      throw new IllegalStateException("bucketCacheSize <= 0; Check " +
        BUCKET_CACHE_SIZE_KEY + " setting and/or server java heap size");
    }
{code}
Setting 0 would mean that we may end up bucketCacheSize as 0?  If we allow the 
hbase-default.xml to have this default value then it would mean that we would 
get a bucketCacheSize as 65536 * 1024 * 1024 as default. (The comment for the 
property is anyway wrong)
If we make the default as 1 in the hbase-default.xml then we will always get 
1024*1024 as the default bucket cache size. 

> 'hbase.bucketcache.size' configuration value is not correct in 
> hbase-default.xml 
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-13320
>                 URL: https://issues.apache.org/jira/browse/HBASE-13320
>             Project: HBase
>          Issue Type: Bug
>          Components: hbase
>    Affects Versions: 2.0.0
>            Reporter: Y. SREENIVASULU REDDY
>            Assignee: Y. SREENIVASULU REDDY
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13320.patch, HBASE-v2-13320.patch
>
>
> In  hbase-default.xml  file 
> * 'hbase.bucketcache.size' is not correct
> We either specify it as a float or in MB's and the default value that is 
> mentioned is never used
> {code}
> <property>
> <name>hbase.bucketcache.size</name>
> <value>65536</value>
> <source>hbase-default.xml</source>
> </property>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to