[
https://issues.apache.org/jira/browse/HBASE-13348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384011#comment-14384011
]
Hadoop QA commented on HBASE-13348:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12707756/HBASE-13348-v1.diff
against master branch at commit 5d2c33158c47fc791d4973c5013d7ae50795d3bc.
ATTACHMENT ID: 12707756
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13460//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13460//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13460//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13460//console
This message is automatically generated.
> Separate the thread number configs for meta server and server operations
> ------------------------------------------------------------------------
>
> Key: HBASE-13348
> URL: https://issues.apache.org/jira/browse/HBASE-13348
> Project: HBase
> Issue Type: Improvement
> Components: master
> Reporter: Liu Shaohui
> Assignee: Liu Shaohui
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-13348-v1.diff
>
>
> Currently, the config keys for thread number of meta server and server
> operations in HMaster are same:
> See: HMaster.java #993
> {code}
> this.service.startExecutorService(ExecutorType.MASTER_SERVER_OPERATIONS,
> conf.getInt("hbase.master.executor.serverops.threads", 5));
>
> this.service.startExecutorService(ExecutorType.MASTER_META_SERVER_OPERATIONS,
> conf.getInt("hbase.master.executor.serverops.threads", 5));
> {code}
> In large cluster, we usually enlarge the thread number for server operation
> separately to make the master handle regionserver shutdown events quickly
> in some extremely cases.
> So I think we need separate the thread number config for the two operations.
> Suggestions are welcomed. Thanks~
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
