[
https://issues.apache.org/jira/browse/HBASE-4507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117647#comment-13117647
]
jirapos...@reviews.apache.org commented on HBASE-4507:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2118/#review2176
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
<https://reviews.apache.org/r/2118/#comment5070>
expected is not needed here.
src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
<https://reviews.apache.org/r/2118/#comment5071>
Should be existence.
src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
<https://reviews.apache.org/r/2118/#comment5072>
Should be executed.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<https://reviews.apache.org/r/2118/#comment5073>
I don't see this parameter below.
I think these four lines can be moved into the body of the method.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<https://reviews.apache.org/r/2118/#comment5076>
Writable parameter is missing here.
It would be nice to add it now.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<https://reviews.apache.org/r/2118/#comment5078>
Should be checkAndPut
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<https://reviews.apache.org/r/2118/#comment5079>
How about naming this method doTimestampsClash ?
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<https://reviews.apache.org/r/2118/#comment5081>
I wish there is a better way to handle this situation :-(
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<https://reviews.apache.org/r/2118/#comment5080>
'that of the' can be omitted.
- Ted
On 2011-09-29 21:10:29, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2118/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-29 21:10:29)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Adds a checkAndPut that takes a timestamp
bq.
bq.
bq. This addresses bug hbase-4507.
bq. https://issues.apache.org/jira/browse/hbase-4507
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 3679c02
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 7cbdb98
bq. src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
0c06f4f
bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
99b34cc
bq.
bq. Diff: https://reviews.apache.org/r/2118/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Create checkAndPut variant that exposes timestamp / UUID
> --------------------------------------------------------
>
> Key: HBASE-4507
> URL: https://issues.apache.org/jira/browse/HBASE-4507
> Project: HBase
> Issue Type: Sub-task
> Reporter: Ted Yu
> Assignee: stack
>
> Michael checked the checkAndPut which doesn't expose timestamp. A variant of
> checkAndPut should be created to expose timestamp which is written into a
> column specified by additional parameters.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
