[
https://issues.apache.org/jira/browse/HBASE-13368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389182#comment-14389182
]
Hadoop QA commented on HBASE-13368:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12708453/HBASE-13368.patch
against master branch at commit f1f4b6618334767d0da0f47965309b21676e7e9f.
ATTACHMENT ID: 12708453
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13509//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13509//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13509//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13509//console
This message is automatically generated.
> Hash.java is declared as public Interface - but it should be Private
> --------------------------------------------------------------------
>
> Key: HBASE-13368
> URL: https://issues.apache.org/jira/browse/HBASE-13368
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.0.0, 1.1.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Priority: Trivial
> Attachments: HBASE-13368.patch
>
>
> Currently Hash.java is marked as public. But we are not allowing the user to
> configure his own Hash.java impl using FQCN. It is currently working as an
> enum based type.
> So this class should be an Private interface and not a direct user facing
> interface. Thanks to Anoop for confirming on this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
