[
https://issues.apache.org/jira/browse/HBASE-13335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389395#comment-14389395
]
Jonathan Lawlor commented on HBASE-13335:
-----------------------------------------
+1, these changes look good to me. Those tests look great.
It may also be a good idea to extend TestSizeFailures so that it also tests to
ensure that all data is seen when the scan is small (e.g. perform that same
scan near the end with but configure it with Scan.setSmall(true)). Even though
that wouldn't be a "small" scan, it would test to make sure the fix behaves as
expected.
> Update ClientSmallScanner and ClientSmallReversedScanner
> --------------------------------------------------------
>
> Key: HBASE-13335
> URL: https://issues.apache.org/jira/browse/HBASE-13335
> Project: HBase
> Issue Type: Sub-task
> Components: Client
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.13
>
> Attachments: HBASE-13335-0.98-v1.patch,
> HBASE-13335-branch-1-v1.patch, HBASE-13335-v1.patch, HBASE-13335.patch
>
>
> Some follow-on work for HBASE-13262:
> it's unlikely that clients using the small scanners would get enough data to
> run into the initial bug, but the scanner implementations should still adhere
> to the moreResultsInRegion flag when the server sends it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
