[
https://issues.apache.org/jira/browse/HBASE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117673#comment-13117673
]
jirapos...@reviews.apache.org commented on HBASE-4503:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2119/#review2184
-----------------------------------------------------------
A couple of slight cleanup things, but overall +1.
src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java
<https://reviews.apache.org/r/2119/#comment5084>
Does this file really need to be here? Yeah, its a little whitespace
cleanup, but I don't think its *that* necessary
src/test/java/org/apache/hadoop/hbase/TestInfoServers.java
<https://reviews.apache.org/r/2119/#comment5086>
why not just assertEquals(${desc}, expected, content) here?
src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java
<https://reviews.apache.org/r/2119/#comment5088>
Couldn't this just go into @BeforeClass?
src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java
<https://reviews.apache.org/r/2119/#comment5090>
nitpick: just use iterable properties here?
Also, maybe abstract this into a single checking method? Not gaining a
whole lot, but saves you some code copy.
src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
<https://reviews.apache.org/r/2119/#comment5093>
nitpick: why drop the import?
src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java
<https://reviews.apache.org/r/2119/#comment5094>
nitpick: (Again) import Assert.*?
src/test/java/org/apache/hadoop/hbase/master/TestDefaultLoadBalancer.java
<https://reviews.apache.org/r/2119/#comment5095>
This doesn't seem to fail into the same review need as the rest of the
patch. I'm ok with the changes, but it would be better if they were for the
same reason.
+/-0
- Jesse
On 2011-09-29 22:01:14, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2119/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-29 22:01:14)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Replace deprecated HBaseClusterTestCase and subclasses.
bq.
bq.
bq. This addresses bug hbase-4503.
bq. https://issues.apache.org/jira/browse/hbase-4503
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/java/org/apache/hadoop/hbase/HBaseClusterTestCase.java c18cddb
bq. src/test/java/org/apache/hadoop/hbase/MultiRegionTable.java a8fd4e5
bq. src/test/java/org/apache/hadoop/hbase/TestHBaseTestingUtility.java
555174a
bq. src/test/java/org/apache/hadoop/hbase/TestInfoServers.java 638df08
bq. src/test/java/org/apache/hadoop/hbase/TestMultiVersions.java
PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java 9023af8
bq. src/test/java/org/apache/hadoop/hbase/TestScanMultipleVersions.java
d7baba4
bq. src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java 221352c
bq. src/test/java/org/apache/hadoop/hbase/client/TestGetRowVersions.java
27842ed
bq. src/test/java/org/apache/hadoop/hbase/client/TestTimestamp.java 9204539
bq. src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java
5a5c3c6
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableMapReduce.java
0b8ff30
bq. src/test/java/org/apache/hadoop/hbase/mapreduce/TestTimeRangeMapRed.java
a772360
bq.
src/test/java/org/apache/hadoop/hbase/master/TestDefaultLoadBalancer.java
a4cd9a3
bq.
src/test/java/org/apache/hadoop/hbase/regionserver/DisabledTestRegionServerExit.java
5b8b464
bq. src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
5802686
bq.
bq. Diff: https://reviews.apache.org/r/2119/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Purge deprecated HBaseClusterTestCase
> -------------------------------------
>
> Key: HBASE-4503
> URL: https://issues.apache.org/jira/browse/HBASE-4503
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Assignee: stack
> Attachments: 4503-v2.txt, 4503.txt
>
>
> It could gain us a few minutes on overall test run in the cases where we
> don't spin up a cluster for each test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
