[
https://issues.apache.org/jira/browse/HBASE-13341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392100#comment-14392100
]
Dima Spivak commented on HBASE-13341:
-------------------------------------
Oops, disregard the above. (Wrong JIRA). Only two things are nits:
1. Put a period at the end of the usage message addition to be consistent with
the other lines.
2. Change the dereference from {{"$ALL" != "true"}} to {{"$\{ALL}" != "true}},
again, just to be consistent with the rest of the script.
+1!
> Add option to disable filtering on interface annotations for the API
> compatibility report
> -----------------------------------------------------------------------------------------
>
> Key: HBASE-13341
> URL: https://issues.apache.org/jira/browse/HBASE-13341
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-13341.patch
>
>
> The API compatibility checker script added in HBASE-12808 passes a file
> containing annotations to the JavaACC tool. When JavaACC is invoked with that
> option it will filter out all interfaces that do not have that annotation. We
> should add a command line option to the compatibility checker which turns off
> this filtering in case we want to look at the impact of changes to all
> interfaces, even private ones.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
