[
https://issues.apache.org/jira/browse/HBASE-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392116#comment-14392116
]
Srikanth Srungarapu commented on HBASE-13370:
---------------------------------------------
Though I'm not well versed with PE tool, this change looks simple. And my guess
is that warnings by QA Bot have nothing to do with this issue.
+1 lgtm.
Couple of trivial things which you can fix while pushing the changes. Please
move this block
{code}
+ final String addColumns = "--addColumns=";
+ if (cmd.startsWith(addColumns)) {
+ opts.addColumns =
Boolean.parseBoolean(cmd.substring(addColumns.length()));
+ continue;
+ }
{code}
to before {{if (isCommandClass(cmd))}} block to group all options together and
also you might want to leave space before true in {{Default:true}}.
> PE tool could give option for using Explicit Column Tracker which leads to
> seeks
> --------------------------------------------------------------------------------
>
> Key: HBASE-13370
> URL: https://issues.apache.org/jira/browse/HBASE-13370
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 1.0.0, 1.0.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Attachments: HBASE-13370.patch
>
>
> Currently in PE tool all the scans and gets adds explicitly the columns to be
> scanned. The tool by default adds only one Qualifier. Doing this addColumns
> leads to Explicit Column Tracker which does seeks frequently. If we want to
> know a simple scan performance as a basic scenario then we should have the
> option to add this columns explicitly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
