[
https://issues.apache.org/jira/browse/HBASE-13397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394645#comment-14394645
]
stack commented on HBASE-13397:
-------------------------------
bq. do you think that isInRequestContext() wasn't not useful?
In every location, as I read it, it is just a gate on whether it is ok to go
get the 'user' from the current RPC context. Nowhere is it used to ask is there
an actual RPC request ongoing. Looking at current state of code, the method is
misnamed and shouldn't have been exposed in the first place given when we go
get the user, we check if an ongoing RPC anyways returning null if not (this
behavior is maintained).
Perhaps I have it wrong. Lets see what hadoopqa says and I'll try it on cluster
before commit.
Thanks for the review [~mbertozzi]
> Purge duplicate rpc request thread local
> ----------------------------------------
>
> Key: HBASE-13397
> URL: https://issues.apache.org/jira/browse/HBASE-13397
> Project: HBase
> Issue Type: Bug
> Components: rpc
> Reporter: stack
> Assignee: stack
> Attachments: 13397.txt
>
>
> Serverside, in a few locations, code wants access to RPC context to get user
> and remote client address. A thread local makes it so this info is accessible
> anywhere on the processing chain.
> Turns out we have this mechanism twice (noticed by our Matteo). This patch
> purges one of the thread locals.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
