[
https://issues.apache.org/jira/browse/HBASE-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484696#comment-14484696
]
Hadoop QA commented on HBASE-13421:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12723810/HBASE-13421-v2.patch
against master branch at commit b6756b39c2ff5675f96a6e82dc4d68ec437f01c4.
ATTACHMENT ID: 12723810
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 148
new or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1922 checkstyle errors (more than the master's current 1921 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13608//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13608//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13608//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13608//console
This message is automatically generated.
> Reduce the number of object creations introduced by HBASE-11544 in scan RPC
> hot code paths
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-13421
> URL: https://issues.apache.org/jira/browse/HBASE-13421
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jonathan Lawlor
> Assignee: Jonathan Lawlor
> Fix For: 2.0.0, 1.1.0
>
> Attachments: HBASE-13421-v1.patch, HBASE-13421-v2.patch
>
>
> HBASE-11544 made NextState the new return type of RegionScanner#nextRaw
> InternalScanner#next to allow state information to be passed back from a
> scanner (it was formerly a boolean indicating whether or not more values
> existed). The change in this return type led to an increased amount of
> objects being created... In the case that a scan spanned millions of rows,
> there was the potential for millions of object to be created.
> This issue looks to reduce the large amount of object creations from
> potentially many to at most one per RPC request.
> Please see the tail of the parent issue for relevant discussion on the design
> decisions related to this solution. This sub-task has been filed as it seems
> more appropriate to address the fix here rather than as an addendum to the
> parent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
