[
https://issues.apache.org/jira/browse/HBASE-13423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486624#comment-14486624
]
Hadoop QA commented on HBASE-13423:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12724080/HBASE-13423.patch
against master branch at commit e2a90a71143f480621ccd935a0b9477d7ee4016f.
ATTACHMENT ID: 12724080
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13632//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13632//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13632//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13632//console
This message is automatically generated.
> Remove duplicate entry for hbase.regionserver.regionSplitLimit in
> hbase-default.xml
> -----------------------------------------------------------------------------------
>
> Key: HBASE-13423
> URL: https://issues.apache.org/jira/browse/HBASE-13423
> Project: HBase
> Issue Type: Bug
> Components: hbase
> Reporter: Apekshit Sharma
> Priority: Minor
> Attachments: HBASE-13423-branch-1.patch, HBASE-13423.patch
>
>
> There are two entries for hbase.regionserver.regionSplitLimit in
> hbase-default.xml
> {code:xml}
> <property>
> <name>hbase.regionserver.regionSplitLimit</name>
> <value>2147483647</value>
> <description>Limit for the number of regions after which no more region
> splitting should take place. This is not a hard limit for the number of
> regions but acts as a guideline for the regionserver to stop splitting
> after
> a certain limit. Default is MAX_INT; i.e. do not block
> splitting.</description>
> </property>
> ....
> ....
> <property>
> <name>hbase.regionserver.regionSplitLimit</name>
> <value>1000</value>
> <description>
> Limit for the number of regions after which no more region splitting
> should take place.
> This is not hard limit for the number of regions but acts as a
> guideline for the regionserver
> to stop splitting after a certain limit. Default is set to 1000.
> </description>
> </property>
> {code}
> Since property setting it to 1000 comes later, that's the real default value
> for now. From /conf of a master
> {code:xml}
> <property>
> <name>hbase.regionserver.regionSplitLimit</name>
> <value>1000</value>
> <source>hbase-default.xml</source>
> </property>
> {code}
> Which will be right default value to keep moving forward?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
