[
https://issues.apache.org/jira/browse/HBASE-13454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492100#comment-14492100
]
Hadoop QA commented on HBASE-13454:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12724750/HBASE-13454-0.94.patch
against 0.94 branch at commit e75c6201c69e57416525135a397a971ad4d1b902.
ATTACHMENT ID: 12724750
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
124 warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13679//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13679//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13679//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13679//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13679//console
This message is automatically generated.
> SecureClient#setupIOStreams should handle all Exception
> -------------------------------------------------------
>
> Key: HBASE-13454
> URL: https://issues.apache.org/jira/browse/HBASE-13454
> Project: HBase
> Issue Type: Bug
> Components: Client, security
> Affects Versions: 0.94.27
> Reporter: cuijianwei
> Assignee: cuijianwei
> Attachments: HBASE-13454-0.94.patch
>
>
> Similar to [HBASE-9256 | https://issues.apache.org/jira/browse/HBASE-9256],
> SecureClient#setupIOStreams should also catch up all Exception. In our
> production environment, an OutOfMemoryError is thrown in
> SecureClient#setupIOStreams, leaving an unclosed SecureConnection with its
> inputStream/outputStream still null. Therefore, following calls will be
> attached to this connection and will encounter NPE in HBaseClient#sendParam:
> {code}
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.ipc.HBaseClient$Connection.sendParam(HBaseClient.java:619)
> at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:977)
> at
> org.apache.hadoop.hbase.ipc.SecureRpcEngine$Invoker.invoke(SecureRpcEngine.java:107)
> at $Proxy21.replicateLogEntries(Unknown Source)
> at
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.shipEdits(ReplicationSource.java:772)
> at
> org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.run(ReplicationSource.java:451)
> {code}
> We'd fix this in 0.94.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
