[ 
https://issues.apache.org/jira/browse/HBASE-13078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492979#comment-14492979
 ] 

Josh Elser commented on HBASE-13078:
------------------------------------

Ok, that makes some more sense. I need to look more at how HBase uses the 
HTrace APIs to see if there is more we can assert over the ThreadLocal used to 
maintain the current span (assuming that hasn't changed since last I looked at 
htrace)

Filed HBASE-13458 for this.

> IntegrationTestSendTraceRequests is a noop
> ------------------------------------------
>
>                 Key: HBASE-13078
>                 URL: https://issues.apache.org/jira/browse/HBASE-13078
>             Project: HBase
>          Issue Type: Test
>          Components: integration tests
>            Reporter: Nick Dimiduk
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 2.0.0, 1.1.0, 0.98.13, 1.0.2
>
>         Attachments: HBASE-13078-0.98-removal.patch, 
> HBASE-13078-0.98-v1.patch, HBASE-13078-v1.patch, HBASE-13078.patch
>
>
> While pair-debugging with [~jeffreyz] on HBASE-13077, we noticed that 
> IntegrationTestSendTraceRequests doesn't actually assert anything. This test 
> should be converted to use a mini cluster, setup a POJOSpanReceiver, and then 
> verify the spans collected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to