[
https://issues.apache.org/jira/browse/HBASE-13417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494142#comment-14494142
]
Hadoop QA commented on HBASE-13417:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12725201/HBASE-13417.patch
against master branch at commit 4f151444b58ae85b93f76254961358932e0ffb9b.
ATTACHMENT ID: 12725201
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13695//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13695//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13695//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13695//console
This message is automatically generated.
> batchCoprocessorService() does not handle NULL keys
> ---------------------------------------------------
>
> Key: HBASE-13417
> URL: https://issues.apache.org/jira/browse/HBASE-13417
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
> Affects Versions: 1.0.0
> Reporter: Lars George
> Priority: Minor
> Labels: noob
> Fix For: 2.0.0, 1.1.0, 1.0.2
>
> Attachments: HBASE-13417.patch
>
>
> The JavaDoc for {{batchCoprocessorService()}} reads:
> {noformat}
> * @param startKey
> * start region selection with region containing this row. If {@code
> null}, the
> * selection will start with the first table region.
> * @param endKey
> * select regions up to and including the region containing this row.
> If {@code null},
> * selection will continue through the last table region.
> {noformat}
> Setting the call to {{null}} keys like so
> {code}
> Map<byte[], CountResponse> results = table.batchCoprocessorService(
> RowCountService.getDescriptor().findMethodByName("getRowCount"),
> request, null, null, CountResponse.getDefaultInstance());
> {code}
> yields an exception:
> {noformat}
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.util.Bytes.compareTo(Bytes.java:1187)
> at
> org.apache.hadoop.hbase.client.HTable.getKeysAndRegionsInRange(HTable.java:744)
> at
> org.apache.hadoop.hbase.client.HTable.getKeysAndRegionsInRange(HTable.java:723)
> at
> org.apache.hadoop.hbase.client.HTable.batchCoprocessorService(HTable.java:1801)
> at
> org.apache.hadoop.hbase.client.HTable.batchCoprocessorService(HTable.java:1778)
> at coprocessor.EndpointBatchExample.main(EndpointBatchExample.java:60)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)
> {noformat}
> This is caused by the call shipping off the keys to {{getStartKeysInRange()}}
> as-is and that method uses {{Bytes.compareTo()}} on the {{null}} keys and
> fails.
> One can work around using {{HConstants.EMPTY_START_ROW,
> HConstants.EMPTY_END_ROW}} instead, but that is not documented, nor standard
> behavior. Need to handle {{null}} keys as advertised.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
