[ 
https://issues.apache.org/jira/browse/HBASE-13453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495602#comment-14495602
 ] 

Hadoop QA commented on HBASE-13453:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12725300/HBASE-13453.patch
  against master branch at commit 4f151444b58ae85b93f76254961358932e0ffb9b.
  ATTACHMENT ID: 12725300

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13705//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13705//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13705//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13705//console

This message is automatically generated.

> Master should not bind to region server ports
> ---------------------------------------------
>
>                 Key: HBASE-13453
>                 URL: https://issues.apache.org/jira/browse/HBASE-13453
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Enis Soztutar
>            Assignee: Devaraj Das
>            Priority: Critical
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: 34111-2.txt, HBASE-13453.patch, HBASE-13453.patch
>
>
> In 1.0, master by default binds to the region server ports (rpc and info). We 
> have done it so thinking that in the long term, master and meta co-location 
> will be default, and we can merge the master and region server as a single 
> daemon. 
> Over at HBASE-11165, if the conclusion end up being that meta will not be 
> colocated at all, then master hosting a region server will just become an 
> implementation detail. [[email protected]] says that we might never allow 
> master to host regions. 
> Now, we are stuck in a state where we have made master bind to RS ports in 
> 1.0, which might create some confusion (and frustration) for small cluster 
> users who traditionally used to host a master and a region server on the same 
> node.
> I think we should undo this in 1.1 and use the previous master ports (16000) 
> and not bind to 16030, so that the user does not need to do anything to bring 
> up a RS on the same host. At least users going from 0.98 -> 1.1 will not take 
> a hit. Users going from 1.0 -> 1.1 will see changed default ports. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to