[ 
https://issues.apache.org/jira/browse/HBASE-13477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497292#comment-14497292
 ] 

Hadoop QA commented on HBASE-13477:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12725707/HBASE-13477-v1.patch
  against master branch at commit 682a29a57f73b836859b3d3e1048fc82d64e8fe3.
  ATTACHMENT ID: 12725707

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 
1924 checkstyle errors (more than the master's current 1910 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +    this.exceptionsOOO = 
this.getMetricsRegistry().newCounter(EXCEPTIONS_OOO_NAME,EXCEPTIONS_TYPE_DESC, 
0l);
+    this.exceptionsBusy = 
this.getMetricsRegistry().newCounter(EXCEPTIONS_BUSY_NAME,EXCEPTIONS_TYPE_DESC, 
0l);
+    this.exceptionsUnknown = 
this.getMetricsRegistry().newCounter(EXCEPTIONS_UNKNOWN_NAME,EXCEPTIONS_TYPE_DESC,
 0l);
+    this.exceptionsSanity = 
this.getMetricsRegistry().newCounter(EXCEPTIONS_SANITY_NAME,EXCEPTIONS_TYPE_DESC,
 0l);
+    this.exceptionsMoved = 
this.getMetricsRegistry().newCounter(EXCEPTIONS_MOVED_NAME,EXCEPTIONS_TYPE_DESC,
 0l);
+    this.exceptionsNSRE = 
this.getMetricsRegistry().newCounter(EXCEPTIONS_NSRE_NAME,EXCEPTIONS_TYPE_DESC, 
0l);

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):       
at 
org.apache.hadoop.hbase.io.crypto.aes.TestAES.testAlternateRNG(TestAES.java:89)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13717//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13717//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13717//artifact/patchprocess/checkstyle-aggregate.html

                Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13717//console

This message is automatically generated.

> Create metrics on failed requests
> ---------------------------------
>
>                 Key: HBASE-13477
>                 URL: https://issues.apache.org/jira/browse/HBASE-13477
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.0, 2.0.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13477-v1.patch, HBASE-13477-v2.patch, 
> HBASE-13477.patch
>
>
> Add a metric on how many requests failed/errored out.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to