[
https://issues.apache.org/jira/browse/HBASE-13456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499473#comment-14499473
]
Hadoop QA commented on HBASE-13456:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12725579/HBASE-13456-master-v2.patch
against master branch at commit 7fb6055ed7304b05a383a730b64e55e41772bcf8.
ATTACHMENT ID: 12725579
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13731//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13731//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13731//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13731//console
This message is automatically generated.
> Improve HFilePrettyPrinter first hbase:meta region processing
> --------------------------------------------------------------
>
> Key: HBASE-13456
> URL: https://issues.apache.org/jira/browse/HBASE-13456
> Project: HBase
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0, 0.98.12
> Environment: x86_64 GNU/Linux
> Reporter: Samir Ahmic
> Assignee: Samir Ahmic
> Priority: Minor
> Attachments: HBASE-13456-0.98-v2.patch, HBASE-13456-0.98.patch,
> HBASE-13456-master-v2.patch, HBASE-13456-master.patch
>
>
> HFilePrettyPrinter have couple of small issues when -r option is used with
> hbase:meta region as argument:
> 1. Processing files in oldWals and recovered.edits directories
> {code}
> $ hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter -v -r
> hbase:meta,,1
> Number of region files found -> 3
> Found file[1] ->
> hdfs://P3cluster/hbase/data/hbase/meta/1588230740/info/e1d395908f8c43d2b22bb3a630728ebf
> Found file[2] ->
> hdfs://P3cluster/hbase/data/hbase/meta/1588230740/info/e30faa185198449b9cb2eeb5589ebd1b
> Found file[3] ->
> hdfs://P3cluster/hbase/data/hbase/meta/1588230740/oldWALs/hlog.1428309293399
> Scanning ->
> hdfs://P3cluster/hbase/data/hbase/meta/1588230740/info/e1d395908f8c43d2b22bb3a630728ebf
> Scanning ->
> hdfs://P3cluster/hbase/data/hbase/meta/1588230740/info/e30faa185198449b9cb2eeb5589ebd1b
> Scanning ->
> hdfs://P3cluster/hbase/data/hbase/meta/1588230740/oldWALs/hlog.1428309293399
> 2015-04-13 14:08:21,461 ERROR [main] hfile.HFilePrettyPrinter: Error reading
> hdfs://P3cluster/hbase/data/hbase/meta/1588230740/oldWALs/hlog.1428309293399
> org.apache.hadoop.hbase.io.hfile.CorruptHFileException: Problem reading HFile
> Trailer from file
> hdfs://P3cluster/hbase/data/hbase/meta/1588230740/oldWALs/hlog.1428309293399
> {code}
> 2. If full region name is passed as argument we have wrong encoded region
> name returned:
> {code}
> hbase org.apache.hadoop.hbase.io.hfile.HFilePrettyPrinter -v -r
> hbase:meta,,1.1588230740
> region dir -> hdfs://P3cluster/hbase/data/hbase/meta/104563571
> 2015-04-13 14:21:43,012 INFO [main] Configuration.deprecation:
> hadoop.native.lib is deprecated. Instead, use io.native.lib.available
> 2015-04-13 14:21:43,711 INFO [main] util.ChecksumType: Checksum using
> org.apache.hadoop.util.PureJavaCrc32
> 2015-04-13 14:21:43,717 INFO [main] util.ChecksumType: Checksum can use
> org.apache.hadoop.util.PureJavaCrc32C
> 2015-04-13 14:21:43,899 ERROR [main] hfile.HFilePrettyPrinter: Error parsing
> command-line options
> java.io.FileNotFoundException: File
> hdfs://P3cluster/hbase/data/hbase/meta/104563571 does not exist.
> {code}
> I have modified HFilePrettyPrinter.java to address this issues. Patch is
> coming soon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
