[ 
https://issues.apache.org/jira/browse/HBASE-13090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501415#comment-14501415
 ] 

Ted Yu commented on HBASE-13090:
--------------------------------

TestScannerHeartbeatMessages fails in branch-1
e.g. 
https://builds.apache.org/job/HBase-1.1/411/testReport/org.apache.hadoop.hbase.regionserver/TestScannerHeartbeatMessages/testScannerHeartbeatMessages/

In TestScannerHeartbeatMessages#testImportanceOfHeartbeats(), there was no 
exception raised when heartbeatsEnabled was set to false:
{code}
    HeartbeatRPCServices.heartbeatsEnabled = false;
    try {
      testCallable.call();
    } catch (Exception e) {
      return;
{code}
Debugging to see what might be the cause.

BTW test table should be deleted at the end of the test:
{code}
@@ -173,6 +173,7 @@ public class TestScannerHeartbeatMessages {

   @AfterClass
   public static void tearDownAfterClass() throws Exception {
+    TEST_UTIL.deleteTable(TABLE_NAME);
     TEST_UTIL.shutdownMiniCluster();
   }

{code}
I sometimes got the following in subsequent test run:
{code}
        at 
org.apache.hadoop.hbase.regionserver.TestScannerHeartbeatMessages.createTestTable(TestScannerHeartbeatMessages.java:139)
        at 
org.apache.hadoop.hbase.regionserver.TestScannerHeartbeatMessages.setUpBeforeClass(TestScannerHeartbeatMessages.java:134)
Caused by: org.apache.hadoop.ipc.RemoteException: 
testScannerHeartbeatMessagesTable
        at 
org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.prepareCreate(CreateTableProcedure.java:283)
        at 
org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:106)
        at 
org.apache.hadoop.hbase.master.procedure.CreateTableProcedure.executeFromState(CreateTableProcedure.java:1)
{code}

> Progress heartbeats for long running scanners
> ---------------------------------------------
>
>                 Key: HBASE-13090
>                 URL: https://issues.apache.org/jira/browse/HBASE-13090
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Andrew Purtell
>            Assignee: Jonathan Lawlor
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: 13090-branch-1.addendum, HBASE-13090-v1.patch, 
> HBASE-13090-v2.patch, HBASE-13090-v3.patch, HBASE-13090-v3.patch, 
> HBASE-13090-v4.patch, HBASE-13090-v6.patch, HBASE-13090-v7.patch
>
>
> It can be necessary to set very long timeouts for clients that issue scans 
> over large regions when all data in the region might be filtered out 
> depending on scan criteria. This is a usability concern because it can be 
> hard to identify what worst case timeout to use until scans are 
> occasionally/intermittently failing in production, depending on variable scan 
> criteria. It would be better if the client-server scan protocol can send back 
> periodic progress heartbeats to clients as long as server scanners are alive 
> and making progress.
> This is related but orthogonal to streaming scan (HBASE-13071). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to