[ 
https://issues.apache.org/jira/browse/HBASE-13469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503824#comment-14503824
 ] 

stack commented on HBASE-13469:
-------------------------------

[~syuanjiang]
bq. I think we should spend our energy to clean up handler code in 1.2 and make 
procedure robust.

Ok. Sounds reasonable. Took a look at the last patch and not much code and it 
has a test (only nit comment is why not have the enum name same as the 
configuration value that turns on the state: i.e. name enums unused, disable, 
enabled... then you could compare the configuration and the enum toString'd... 
No biggie)

> [branch-1.1] Procedure V2 - Make procedure v2 configurable in branch-1.1
> ------------------------------------------------------------------------
>
>                 Key: HBASE-13469
>                 URL: https://issues.apache.org/jira/browse/HBASE-13469
>             Project: HBase
>          Issue Type: Sub-task
>          Components: master
>            Reporter: Enis Soztutar
>            Assignee: Stephen Yuan Jiang
>             Fix For: 1.1.0
>
>         Attachments: HBASE-13469.v1-branch-1.1.patch
>
>
> In branch-1, I think we want proc v2 to be configurable, so that if any 
> non-recoverable issue is found, at least there is a workaround. We already 
> have the handlers and code laying around. It will be just introducing the 
> config to enable / disable. We can even make it dynamically configurable via 
> the new framework. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to