[
https://issues.apache.org/jira/browse/HBASE-13520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504440#comment-14504440
]
Hadoop QA commented on HBASE-13520:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12726788/HBASE-13520-v1.patch
against master branch at commit eb82b8b3098d6a9ac62aa50189f9d4b289f38472.
ATTACHMENT ID: 12726788
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/13750//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/13750//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/13750//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/13750//console
This message is automatically generated.
> NullPointerException in TagRewriteCell
> --------------------------------------
>
> Key: HBASE-13520
> URL: https://issues.apache.org/jira/browse/HBASE-13520
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Josh Elser
> Assignee: Josh Elser
> Fix For: 2.0.0, 1.1.0, 1.0.2
>
> Attachments: HBASE-13520-v1.patch, HBASE-13520.patch
>
>
> Found via running {{IntegrationTestIngestWithVisibilityLabels}} with Kerberos
> enabled.
> {noformat}
> 2015-04-20 18:54:36,712 ERROR
> [B.defaultRpcServer.handler=17,queue=2,port=16020] ipc.RpcServer: Unexpected
> throwable object
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.TagRewriteCell.getTagsLength(TagRewriteCell.java:157)
> at
> org.apache.hadoop.hbase.TagRewriteCell.heapSize(TagRewriteCell.java:186)
> at
> org.apache.hadoop.hbase.CellUtil.estimatedHeapSizeOf(CellUtil.java:568)
> at
> org.apache.hadoop.hbase.regionserver.DefaultMemStore.heapSizeChange(DefaultMemStore.java:1024)
> at
> org.apache.hadoop.hbase.regionserver.DefaultMemStore.internalAdd(DefaultMemStore.java:259)
> at
> org.apache.hadoop.hbase.regionserver.DefaultMemStore.upsert(DefaultMemStore.java:567)
> at
> org.apache.hadoop.hbase.regionserver.DefaultMemStore.upsert(DefaultMemStore.java:541)
> at
> org.apache.hadoop.hbase.regionserver.HStore.upsert(HStore.java:2154)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.increment(HRegion.java:7127)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.increment(RSRpcServices.java:504)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.mutate(RSRpcServices.java:2020)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:31967)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2106)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:101)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$2.run(RpcExecutor.java:107)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> HBASE-11870 tried to be tricky when only the tags of a {{Cell}} need to be
> altered in the write-pipeline by creating a {{TagRewriteCell}} which avoided
> copying all components of the original {{Cell}}. In an attempt to help free
> the tags on the old cell that we wouldn't be referencing anymore,
> {{TagRewriteCell}} nulls out the original {{byte[] tags}}.
> This causes a problem in that the implementation of {{heapSize()}} as it
> {{getTagsLength()}} on the original {{Cell}} instead of the on {{this}}.
> Because the tags on the passed in {{Cell}} (which was also a
> {{TagRewriteCell}}) were null'ed out in the constructor, this results in a
> NPE by the byte array is null.
> I believe this isn't observed in normal, unsecure deployments because there
> is only one RegionObserver/Coprocessor loaded that gets invoked via
> {{postMutationBeforeWAL}}. When there is only one RegionObserver, the
> TagRewriteCell isn't passed another TagRewriteCell, but instead a cell from
> the wire/protobuf. This means that the optimization isn't performed. When we
> have two (or more) observers that a TagRewriteCell passes through (and a new
> TagRewriteCell is created and the old TagRewriteCell's tags array is nulled),
> this enables the described-above NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
