[
https://issues.apache.org/jira/browse/HBASE-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506597#comment-14506597
]
Lars George commented on HBASE-13522:
-------------------------------------
There is more broken it seems. We say this in the Thrift definition:
{code}
/**
* Returns the scanner's current row value and advances to the next
* row in the table. When there are no more rows in the table, or a key
* greater-than-or-equal-to the scanner's specified stopRow is reached,
* an empty list is returned.
*
* @return a TRowResult containing the current row and a map of the columns
to TCells.
*
* @throws IllegalArgument if ScannerID is invalid
*
* @throws NotFound when the scanner reaches the end
*/
list<TRowResult> scannerGet(
/** id of a scanner returned by scannerOpen */
1:ScannerID id
) throws (1:IOError io, 2:IllegalArgument ia)
{code}
Yet we never throw {{NotFound}} anywhere it seems. The DemoClient.php keeps
iterating over the first scanner loop forever. We actually return an empty
result list instead.
> [Thrift] DemoClient.php is out of date for Thrift 0.9.x and current HBase
> -------------------------------------------------------------------------
>
> Key: HBASE-13522
> URL: https://issues.apache.org/jira/browse/HBASE-13522
> Project: HBase
> Issue Type: Bug
> Components: Thrift
> Affects Versions: 1.0.0, 0.98.12
> Reporter: Lars George
>
> Bucket list:
> * Assumes all Thrift files are under $THRIFT_SRC_HOME/lib/php/src but is now
> split between “src” and “lib"
> * Apparently casing is no issue as DemoClient.php refers to lowercase
> directories and finds them in Camel-Cased directories.
> * Tries row with empty row key but without wrapping into try/catch
> * Does assume non-UTF8 is not allowed in row key, and therefore page fails to
> load because they are valid
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
