[ 
https://issues.apache.org/jira/browse/HBASE-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-4526:
-------------------------

       Resolution: Fixed
    Fix Version/s: 0.92.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Committed to 0.92 branch and trunk.  Thank you for the patch Roman.
                
> special case for stopping master in hbase-daemon.sh is no longer required
> -------------------------------------------------------------------------
>
>                 Key: HBASE-4526
>                 URL: https://issues.apache.org/jira/browse/HBASE-4526
>             Project: HBase
>          Issue Type: Bug
>          Components: scripts
>    Affects Versions: 0.90.4
>            Reporter: Roman Shaposhnik
>            Assignee: Roman Shaposhnik
>            Priority: Minor
>             Fix For: 0.92.0
>
>         Attachments: HBASE-4526.patch.txt
>
>
> Now that HBASE-4209 is finally done (many thanks to stack for help and 
> encouragement!) I don't think there's any reason to keep this bit of code in 
> hbase-daemon.sh:
> {noformat}
>         if [ "$command" = "master" ]; then
>           echo "`date` Killing $command" >> $loglog
>           kill -9 `cat $pid` > /dev/null 2>&1
>         else
>           echo "`date` Killing $command" >> $loglog
>           kill `cat $pid` > /dev/null 2>&1
>         fi
> {noformat}
> I suggest we remove the special case completely, since I don't think it 
> serves any useful purpose (patch attached).
> Now, as an additional precautionary measure. We can try to follow up with a 
> SIGKILL once a certain timeout expires.
> Let me know if you think it is necessary to do so and I'll update the patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to