[ 
https://issues.apache.org/jira/browse/HBASE-13526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508180#comment-14508180
 ] 

Hadoop QA commented on HBASE-13526:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12727345/HBASE-13526.patch
  against master branch at commit afd7a8f4742ddbc575b45fc141a75551b55c56f5.
  ATTACHMENT ID: 12727345

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13781//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13781//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13781//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/13781//console

This message is automatically generated.

> TestRegionServerReportForDuty can be flaky: hang or timeout
> -----------------------------------------------------------
>
>                 Key: HBASE-13526
>                 URL: https://issues.apache.org/jira/browse/HBASE-13526
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0, 1.1.0, 0.98.12
>            Reporter: Jerry He
>            Assignee: Jerry He
>            Priority: Minor
>         Attachments: HBASE-13526.patch
>
>
> This test case is from HBASE-13317.
> The test uses a custom region server to simulate reportForDuty in a master 
> failover case.  This custom RS would start, then the primary master would 
> fail, then the custom RS would  reportForDuty to the second master after 
> master failover.
> The test occasionally will hang or timeout.
> The root cause is that during first master initialization, the master would 
> assign meta (and create and assign namespace table). It is possible that the 
> meta is assigned to the custom RS, which has started (place a rs node on the 
> ZK), but will not really check-in and be online. Then the master will go thru 
> multiple re-assignment, which can be lengthy and cause trouble.
> There are a couple of issues I see in the master assignment code:
> 1.  Master puts all the region servers obtained from ZK rs node into the 
> online server list, including those that have not checked-in via RPC.  And we 
> will assign meta or other regions based on whole list.
> 2. When one assign plan fails, we don't exclude the failed server when 
> picking the next destination, which may prolong the assignment process.
> I will provide a patch to fix the test case.  The other issues mentioned are 
> up to discussion.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to