[
https://issues.apache.org/jira/browse/HBASE-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507253#comment-14507253
]
Anoop Sam John edited comment on HBASE-13496 at 4/23/15 3:16 AM:
-----------------------------------------------------------------
Thanks Stack.
I also followed the sample and run JMH. On Java 8 the throughput gain what I
got is ~5% and on Java7 it was 7%
Edit: With out patch case throughput itself is better when coming to Java 8
and that is why lesser % of gain. Java 8 is better performing in any case.
was (Author: anoop.hbase):
Thanks Stack.
I also followed the sample and run JMH. On Java 8 the throughput gain what I
got is ~5% and on Java7 it was 7%
> Make Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo inlineable
> -----------------------------------------------------------------------------
>
> Key: HBASE-13496
> URL: https://issues.apache.org/jira/browse/HBASE-13496
> Project: HBase
> Issue Type: Sub-task
> Components: Scanners
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 2.0.0, 1.2.0
>
> Attachments: ByteBufferUtils.java, HBASE-13496.patch,
> HBASE-13496.patch, OffheapVsOnHeapCompareTest.java, onheapoffheapcompare.tgz
>
>
> While testing with some other perf comparisons I have noticed that the above
> method (which is very hot in read path) is not getting inline
> bq.@ 16
> org.apache.hadoop.hbase.util.Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo
> (364 bytes) hot method too big
> We can do minor refactoring to make it inlineable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
