[
https://issues.apache.org/jira/browse/HBASE-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anoop Sam John updated HBASE-13496:
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.0.2
1.1.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Pushed to 0.98+ branches. Thanks for reveiws Andy & Stack.
Thanks a lot Stack for testing with JMH and sharing the test. Helped me a lot
to learn it and start doing same for other micro benchmarks.
> Make Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo inlineable
> -----------------------------------------------------------------------------
>
> Key: HBASE-13496
> URL: https://issues.apache.org/jira/browse/HBASE-13496
> Project: HBase
> Issue Type: Sub-task
> Components: Scanners
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 2.0.0, 1.1.0, 1.0.2, 1.2.0
>
> Attachments: ByteBufferUtils.java, HBASE-13496.patch,
> HBASE-13496.patch, OffheapVsOnHeapCompareTest.java, onheapoffheapcompare.tgz
>
>
> While testing with some other perf comparisons I have noticed that the above
> method (which is very hot in read path) is not getting inline
> bq.@ 16
> org.apache.hadoop.hbase.util.Bytes$LexicographicalComparerHolder$UnsafeComparer::compareTo
> (364 bytes) hot method too big
> We can do minor refactoring to make it inlineable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
