[
https://issues.apache.org/jira/browse/HBASE-13529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508545#comment-14508545
]
Srikanth Srungarapu commented on HBASE-13529:
---------------------------------------------
Changes look good to me.
Just a thought. Does it make sense to create a new class say ProcedureConstants
and move all the configuration params including those in ProcedureExecutor over
there?
> Procedure v2 - WAL Improvements
> -------------------------------
>
> Key: HBASE-13529
> URL: https://issues.apache.org/jira/browse/HBASE-13529
> Project: HBase
> Issue Type: Sub-task
> Components: proc-v2
> Affects Versions: 2.0.0, 1.1.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Priority: Blocker
> Fix For: 2.0.0, 1.1.0
>
> Attachments: HBASE-13529-v0.patch, HBASE-13529-v1.patch,
> HBASE-13529-v2.patch, ProcedureStoreTest.java
>
>
> from the discussion in HBASE-12439 the wal was resulting slow.
> * there is an error around the awake of the slotCond.await(), causing more
> wait then necessary
> * ArrayBlockingQueue is dog slow, replace it with ConcurrentLinkedQueue
> * roll the wal only if reaches a threshold (conf ops) to amortize the cost
> * hsync() is used by default, when the normal wal is using just hflush()
> make it tunable via conf
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
