[
https://issues.apache.org/jira/browse/HBASE-13356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512866#comment-14512866
]
Ted Yu commented on HBASE-13356:
--------------------------------
MultiTableSnapshotInputFormat.java and MultiTableSnapshotInputFormatImpl.java
need Apache license. Add annotation for audience.
There're several long lines - please limit line width to 100 characters.
{code}
125 * Sets up the job for reading from one or more multiple table
snapshots, with one or more scan per snapshot.
{code}
Should 'one or more multiple table snapshots' be 'one or more table snapshots' ?
nit: 'one or more scan' -> 'one or more scans'
{code}
26 public class MultiTableSnapshotInputFormatImpl {
27
28 private static final Log LOG =
LogFactory.getLog(MultiTableSnapshotInputFormat.class);
{code}
Classname for LOG doesn't match the real classname.
{code}
85 for (TableSnapshotInputFormatImpl.InputSplit split : splits) {
86 rtn.add(split);
87 }
{code}
Can you use
https://docs.oracle.com/javase/7/docs/api/java/util/List.html#addAll(java.util.Collection)
?
{code}
177 private Map<String, Path>
generateSnapshotToRestoreDir(Collection<String> snapshots, Path baseRestoreDir)
{
{code}
Name the method generateSnapshotToRestoreDirMapping().
> HBase should provide an InputFormat supporting multiple scans in mapreduce
> jobs over snapshots
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-13356
> URL: https://issues.apache.org/jira/browse/HBASE-13356
> Project: HBase
> Issue Type: New Feature
> Components: mapreduce
> Reporter: Andrew Mains
> Assignee: Andrew Mains
> Priority: Minor
> Attachments: HBASE-13356.patch
>
>
> Currently, HBase supports the pushing of multiple scans to mapreduce jobs
> over live tables (via MultiTableInputFormat) but only supports a single scan
> for mapreduce jobs over table snapshots. It would be handy to support
> multiple scans over snapshots as well, probably through another input format
> (MultiTableSnapshotInputFormat?). To mimic the functionality present in
> MultiTableInputFormat, the new input format would likely have to take in the
> names of all snapshots used in addition to the scans.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
