[ 
https://issues.apache.org/jira/browse/HBASE-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512920#comment-14512920
 ] 

Matteo Bertozzi commented on HBASE-13537:
-----------------------------------------

i'm not good with methods comment so I'll let you decide this.
in theory if we have the comment on the Admin interface it is not needed in 
HBaseAdmin (because you are using @Override), so we can remove the comments on 
the HBaseAdmin side, but the comments on the HBaseAdmin side for v2 version are 
better then the one we have in admin for async() because they explain the 
future stuff, so you should copy/paste them in Admin replacing the ones we 
have).
I'm +1 on the patch, the decision on comments is up to you

> Change the admin interface for async operations to return Future.
> -----------------------------------------------------------------
>
>                 Key: HBASE-13537
>                 URL: https://issues.apache.org/jira/browse/HBASE-13537
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2
>    Affects Versions: 2.0.0
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>         Attachments: HBASE-13537.patch, HBASE-13537.patch, HBASE-13537.patch
>
>
> At the moment, the async operations are returning void. This task aims to 
> change the return type to Future and remove the aysnc wrapper methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to