[
https://issues.apache.org/jira/browse/HBASE-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514681#comment-14514681
]
stack commented on HBASE-5980:
------------------------------
Suggest folks review this one quick cos our mighty [~jonathan.lawlor] is going
back to school EOW [~lhofhansl]
First blush:
.. you need to add this option to the Scan help in the shell else no one will
find it.
Add this to the scan help in shell?
scan 'table', {GET_ALL_METRICS => true}
scan 'table', {GET_METRICS => ['RPC_RETRIES', 'ROWS_FILTERED']}
bq. I think the name of the metrics and shell arguments could be improved, just
chose some easy names to show their usage. Thoughts?
I'd say drop the 'GET_'... because redundant
Patch looks good. Surprisingly little code (patch is big because of generated
code).
On naming of a client-side class server-side metrics, not sure what to do about
that... it is only telling it as it is. Purge the abstract class? Only used
once?
bq. ScanMetrics now contains a mix of both client side and server side metrics
Should we have ClientScanMetrics and ServerScanMetrics?
> Scanner responses from RS should include metrics on rows/KVs filtered
> ---------------------------------------------------------------------
>
> Key: HBASE-5980
> URL: https://issues.apache.org/jira/browse/HBASE-5980
> Project: HBase
> Issue Type: Improvement
> Components: Client, metrics, regionserver
> Affects Versions: 0.95.2
> Reporter: Todd Lipcon
> Assignee: Jonathan Lawlor
> Priority: Minor
> Attachments: HBASE-5980-v1.patch
>
>
> Currently it's difficult to know, when issuing a filter, what percentage of
> rows were skipped by that filter. We should expose some basic counters back
> to the client scanner object. For example:
> - number of rows filtered by row key alone (filterRowKey())
> - number of times each filter response was returned by filterKeyValue() -
> corresponding to Filter.ReturnCode
> What would be slickest is if this could actually return a tree of counters
> for cases where FilterList or other combining filters are used. But a
> top-level is a good start.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
